Add evaluation, multimodal, native tests to run-readme-pr-mps.yml #1410
Conversation
Add evaluation, multimodal, native tests to run-readme-pr-mps.yml
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1410
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 0de9067 with merge base 68b8087 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Just realized that none of the test in this file are being ran:
|
Should be fixed now. Please rerun tests? |
Extend timeout for test-readme-mps to avoid test failing from timeout.
Still timed out @ 50 minutes, increased timeout further. Beyond the "let's extend timeout" bandaid, I'm wondering whether this may be due to us trying to update llvm+openmp with the command Also, MPS is the only set of doc tests using conda, which on the one hand is good because we're testing setup with conda as well, but otoh makes MPS the odd |
| @@ -90,7 +90,7 @@ jobs: | |||
| test-advanced-mps-macos: | |||
| uses: pytorch/test-infra/.github/workflows/macos_job.yml@main | |||
| with: | |||
| runner: macos-m1-14 # neeps MPS, was macos-m1-stable | |||
| runner: macos-m1-14 # needs MPS, was macos-m1-stable | |||
There was a problem hiding this comment.
Nice typo fix, should we land it as separate PR?
Add evaluation, multimodal, native tests to run-readme-pr-mps.yml